Move MySQL-specific fakeMaster/fakeSlave stuff to DatabaseMysqlBase
authorBrad Jorsch <bjorsch@wikimedia.org>
Mon, 13 Jan 2014 19:48:36 +0000 (14:48 -0500)
committerBrad Jorsch <bjorsch@wikimedia.org>
Mon, 13 Jan 2014 20:00:27 +0000 (15:00 -0500)
commitd5f52588a2e6031062cc92833fc9389ff71665a9
treea8ebaaa918123d12a67f589fa7b444b234d73ef0
parentc00ab2af44e004865b020fb4fba799ae898032e2
Move MySQL-specific fakeMaster/fakeSlave stuff to DatabaseMysqlBase

Probably the fakeMaster/fakeSlave stuff was originally intended to be
generic, but the existing code in Database.php is making some very
MySQL-specific assumptions. So let's evict it from Database.php (except
for the minimal support functions) and put it in DatabaseMysqlBase where
it makes more sense.

This also takes care of fixing the breakage described in I5d2a1696 by
reverting Id6268193 and the problematic bit of I364e192e (again).

Change-Id: I3dc6ca216bf2c2f07d3090e86f2539292e1fa86b
includes/db/Database.php
includes/db/DatabaseMysqlBase.php
includes/db/DatabaseOracle.php
includes/db/DatabasePostgres.php
includes/db/DatabaseUtility.php